Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check multiple audience values #781

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Check multiple audience values #781

merged 2 commits into from
Apr 4, 2023

Conversation

mlsmaycon
Copy link
Collaborator

Describe your changes

Some IDP use different audience for different clients. This update checks HTTP and Device authorization flow audience values.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon
Check multiple audience values
366ea76 
Some IDP use different audience for different clients,
This update checks HTTP and Device authorization flow
audience values
@mlsmaycon mlsmaycon marked this pull request as ready for review April 4, 2023 09:39
gigovich
gigovich suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@gigovich gigovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs to simplify GetAuthAudiences.

@mlsmaycon @gigovich
no need for duplication check
c574d0a 
As we exit on first match, checking for duplication is not required.

Co-authored-by: Givi Khojanashvili <[email protected]>
@mlsmaycon
Copy link
Collaborator Author

LGTM, but needs to simplify GetAuthAudiences.

Thanks, I've accepted the suggestion.

@mlsmaycon mlsmaycon requested a review from gigovich April 4, 2023 13:56
gigovich
gigovich approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@gigovich gigovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlsmaycon mlsmaycon merged commit fe1ea4a into main Apr 4, 2023
@mlsmaycon mlsmaycon deleted the feature/support-device-flow-aud-claim branch April 4, 2023 14:40
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
@mlsmaycon @gigovich
Check multiple audience values (netbirdio#781)
80a56d0 
Some IDP use different audience for different clients. 
This update checks HTTP and Device authorization flow audience values.



---------

Co-authored-by: Givi Khojanashvili <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigovich gigovich gigovich approved these changes

@pascal-fischer pascal-fischer pascal-fischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlsmaycon @gigovich @pascal-fischer