Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/connection listener #777

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fix/connection listener #777

merged 2 commits into from
Apr 3, 2023

Conversation

pappz
Copy link
Contributor

@pappz pappz commented Apr 1, 2023

Describe your changes

Fix add/remove connection listener

In case we call the RemoveConnListener from Java then
we lose the reference from the original instance

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@pappz pappz marked this pull request as ready for review April 3, 2023 13:26
@pappz pappz requested a review from mlsmaycon April 3, 2023 13:26
@pappz pappz merged commit 86f9051 into main Apr 3, 2023
@pappz pappz deleted the fix/connection_listener branch April 3, 2023 14:59
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
Fix add/remove connection listener

In case we call the RemoveConnListener from Java then
we lose the reference from the original instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants