New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAT persistence #745

Merged

pascal-fischer merged 12 commits into main from feature/pat_persistence

Mar 21, 2023

Contributor

pascal-fischer commented Mar 16, 2023

Describe your changes

Added support to store PATs with a user. Also allow lookup of respected user and account by provided PAT.

Issue ticket number and link

Checklist

Is it a bug fix
Is a typo/documentation fix
Is a feature enhancement
It is a refactor
Created tests that fail without the change (if possible)
Extended the README / documentation, if necessary

pascal-fischer and others added 6 commits

March 16, 2023 15:57


          storing and retrieving PATs

b8cab28


          add method to account mock


          fix PAT array split

628a201


          codacy and lint hints

b852198


          Delete pat_handler.go

511ba6d


          remove unnecessary string conversion

e1ef091

mlsmaycon requested review from pappz and gigovich

March 20, 2023 12:24

pascal-fischer added 2 commits

March 20, 2023 16:14


          switch PATs to map and add deletion

e30def1


          add function comments, implement account mock functions and added err…

41a47be

…or handling in tests

pappz requested changes

View reviewed changes

management/server/account.go Show resolved Hide resolved

gigovich reviewed

View reviewed changes

management/server/account.go Outdated Show resolved Hide resolved

pappz previously approved these changes

View reviewed changes

gigovich reviewed

View reviewed changes

management/server/account_test.go Outdated Show resolved Hide resolved

gigovich reviewed

View reviewed changes

management/server/account_test.go Outdated Show resolved Hide resolved

gigovich reviewed

View reviewed changes

management/server/file_store.go Outdated Show resolved Hide resolved

gigovich reviewed

View reviewed changes

management/server/user.go Outdated Show resolved Hide resolved

gigovich previously approved these changes

View reviewed changes

Contributor

gigovich left a comment

LGTM, but it is good if some minor style fixes will be added.


          improve style for tests

94d39ab

pascal-fischer dismissed stale reviews from gigovich and pappz via

94d39ab

March 21, 2023 12:34

pascal-fischer added 3 commits

March 21, 2023 13:56


          change error messages

311b67f


          use "ok" convention for check variables throughout files_store

82af608


          use single line return for SaveAccount

8e47107

pascal-fischer requested a review from gigovich

March 21, 2023 13:27

gigovich approved these changes

View reviewed changes

pascal-fischer merged commit 9c5adfe into main

pascal-fischer deleted the feature/pat_persistence branch

March 21, 2023 13:38

pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request


          Merge pull request netbirdio#745 from netbirdio/feature/pat_persistence

94e07bd

PAT persistence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet