Add version info command to signal server #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlsmaycon
requested changes
Mar 13, 2023
signal/cmd/root.go
Outdated
| @@ -15,14 +15,18 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| // will be replaced with the release version when using goreleaser | |||
| version = "development" | |||
There was a problem hiding this comment.
we moved away from the global var to keep version in a single package system, have a look at https://github.com/netbirdio/netbird/blob/main/client/cmd/version.go, main benefits of this approach is that we can use the system.NetbirdVersion() call in other places and keep consistency
There was a problem hiding this comment.
That package is inside in the client tree. Should I move out the version logic to outer, to the root?
mlsmaycon
approved these changes
Mar 14, 2023
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
Add version command to signal and management servers. The version information will be filled during build time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add version command to signal and management servers.
The version information will be filled during build time.
Issue ticket number and link
Checklist