Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more activity events #663

Merged
merged 10 commits into from
Jan 25, 2023
Prev Previous commit
Next Next commit
Fix nameserver tests compilation
braginini committed Jan 25, 2023

Verified

This commit was signed with the committer’s verified signature.
Byron Sebastian Thiel
commit 4c34df1e0189be23152bbbbcec31c1089f886c26
7 changes: 4 additions & 3 deletions management/server/nameserver_test.go
Original file line number Diff line number Diff line change
@@ -380,6 +380,7 @@ func TestCreateNameServerGroup(t *testing.T) {
testCase.inputArgs.primary,
testCase.inputArgs.domains,
testCase.inputArgs.enabled,
userID,
)

testCase.errFunc(t, err)
@@ -628,7 +629,7 @@ func TestSaveNameServerGroup(t *testing.T) {
}
}

err = am.SaveNameServerGroup(account.Id, nsGroupToSave)
err = am.SaveNameServerGroup(account.Id, userID, nsGroupToSave)

testCase.errFunc(t, err)

@@ -952,7 +953,7 @@ func TestUpdateNameServerGroup(t *testing.T) {
t.Error("account should be saved")
}

updatedRoute, err := am.UpdateNameServerGroup(account.Id, testCase.nsGroupID, testCase.operations)
updatedRoute, err := am.UpdateNameServerGroup(account.Id, testCase.nsGroupID, userID, testCase.operations)
testCase.errFunc(t, err)

if !testCase.shouldCreate {
@@ -1009,7 +1010,7 @@ func TestDeleteNameServerGroup(t *testing.T) {
t.Error("failed to save account")
}

err = am.DeleteNameServerGroup(account.Id, testingNSGroup.ID)
err = am.DeleteNameServerGroup(account.Id, testingNSGroup.ID, userID)
if err != nil {
t.Error("deleting nameserver group failed with error: ", err)
}