Add GetEvents test to account manager

management/server/activity/event.go

@@ -1,6 +1,9 @@
 package activity
 
-import "time"
+import (
+	"sync"
+	"time"
+)
 
 const (
 	// PeerAddedByUser indicates that a user added a new peer to the system
@@ -165,23 +168,44 @@ type Store interface {
 	Close() error
 }
 
-// NoopEventStore implements the Store interface without doing any operations
+// NoopEventStore implements the Store interface storing data in-memory
 type NoopEventStore struct {
+	mu     sync.Mutex
+	nextID uint64
+	events []*Event
 }
 
 // Save sets the Event.ID to 1
 func (store *NoopEventStore) Save(event *Event) (*Event, error) {
-	event.ID = 1
+	store.mu.Lock()
+	defer store.mu.Unlock()
+	if store.events == nil {
+		store.events = make([]*Event, 0)
+	}
+	event.ID = store.nextID
+	store.nextID++
+	store.events = append(store.events, event)
 	return event, nil
 }
 
-// Get returns an empty list of events
+// Get returns a list of ALL events that belong to the given accountID without taking offset, limit and order into consideration
 func (store *NoopEventStore) Get(accountID string, offset, limit int, descending bool) ([]*Event, error) {
-	return []*Event{}, nil
+	store.mu.Lock()
+	defer store.mu.Unlock()
+	events := make([]*Event, 0)
+	for _, event := range store.events {
+		if event.AccountID == accountID {
+			events = append(events, event)
+		}
+	}
+	return events, nil
 }
 
-// Close doesn't close anything
+// Close cleans up the event list
 func (store *NoopEventStore) Close() error {
+	store.mu.Lock()
+	defer store.mu.Unlock()
+	store.events = make([]*Event, 0)
 	return nil
 }
 

management/server/event_test.go

@@ -0,0 +1,63 @@
+package server
+
+import (
+	"github.com/netbirdio/netbird/management/server/activity"
+	"github.com/stretchr/testify/assert"
+	"testing"
+	"time"
+)
+
+func generateAndStoreEvents(t *testing.T, manager *DefaultAccountManager, typ activity.Activity, initiatorID, targetID,
+	accountID string, count int) {
+	for i := 0; i < count; i++ {
+		_, err := manager.eventStore.Save(&activity.Event{
+			Timestamp:   time.Now(),
+			Activity:    typ,
+			InitiatorID: initiatorID,
+			TargetID:    targetID,
+			AccountID:   accountID,
+		})
+		if err != nil {
+			t.Fatal(err)
+		}
+	}
+}
+
+func TestDefaultAccountManager_GetEvents(t *testing.T) {
+	manager, err := createManager(t)
+	if err != nil {
+		return
+	}
+
+	accountID := "accountID"
+
+	t.Run("get empty events list", func(t *testing.T) {
+		events, err := manager.GetEvents(accountID, userID)
+		if err != nil {
+			return
+		}
+		assert.Len(t, events, 0)
+		_ = manager.eventStore.Close() //nolint
+	})
+
+	t.Run("get events", func(t *testing.T) {
+		generateAndStoreEvents(t, manager, activity.PeerAddedByUser, userID, "peer", accountID, 10)
+		events, err := manager.GetEvents(accountID, userID)
+		if err != nil {
+			return
+		}
+
+		assert.Len(t, events, 10)
+		_ = manager.eventStore.Close() //nolint
+	})
+
+	t.Run("get events without duplicates", func(t *testing.T) {
+		generateAndStoreEvents(t, manager, activity.UserJoined, userID, "", accountID, 10)
+		events, err := manager.GetEvents(accountID, userID)
+		if err != nil {
+			return
+		}
+		assert.Len(t, events, 1)
+		_ = manager.eventStore.Close() //nolint
+	})
+}