Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate single account domain input #624

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Validate single account domain input #624

merged 1 commit into from
Dec 13, 2022

Conversation

mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Dec 13, 2022 •
edited
Loading

Describe your changes

Fix a single account mode issue with invalid domains.

Where retrieving an account with invalid domains caused users to join separate accounts

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon mlsmaycon requested a review from braginini December 13, 2022 11:09
@braginini braginini merged commit 6b32e2d into main Dec 13, 2022
@braginini braginini deleted the validate-single-account-domain branch December 13, 2022 12:43
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
@mlsmaycon
Validate single account domain input (netbirdio#624)
08d066d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braginini braginini braginini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlsmaycon @braginini