HA Network Routes: prevent routing directly-accessible networks through VPN interface

[nazarewk]

Describe your changes

It prevents Server from adding rules to route directly accessible/own networks through VPN when the route is in HA mode (has more than 1 entry):

1. the code was checking membership against a single Network Route entry with equality operator on Peer attribute:
   1. there is 1 Route per Peer
   2. second (HA) Route entry did not pass the check because it was not the server
   3. rule for routing the traffic through VPN interface is created
   4. host X is routing through host Y
   5. host Y is routing through host X
   6. (i assume) we have a routing loop passing packets back and forth between HA hosts instead of going to the real network
2. The code fixes above issue by checking NetID instead of Peer values

see the linked issue for more details

Issue ticket number and link

fixes: #598

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[CLAassistant]

All committers have signed the CLA.

[mlsmaycon]

Thank you so much for your PR @nazarewk, it is definitely helping with the case you described.

I have a few notes that I took into consideration on my request for changes:

In multi-hop routing cases, you want to route traffic via the VPN interface as the routing peer might be an intermediate router. In that case, will make sense to have different network routes for each hop.

Also, to document, with PR #606 we will be able to prevent similar case by using different distribution groups for routes, but only when different groups are used with routes and peers.

[mlsmaycon]

@nazarewk thank you for the changes and hanging thought all the requests.