Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] Fix networks net map generation with posture checks #3124

Merged
merged 19 commits into from
Dec 30, 2024

Conversation

mlsmaycon
Copy link
Collaborator

Describe your changes

Checking for posture checks was missing when generating network map resources for Networks objects. This PR fixes this issue.

It also optimizes some methods from the network map generations to improve performance

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon mlsmaycon requested a review from Copilot December 30, 2024 09:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated 3 comments.

Files not reviewed (3)
  • go.mod: Language not supported
  • management/server/route.go: Evaluated as low risk
  • management/server/account_test.go: Evaluated as low risk

management/server/types/account_test.go Outdated Show resolved Hide resolved
management/server/types/account_test.go Outdated Show resolved Hide resolved
management/server/types/account_test.go Outdated Show resolved Hide resolved
@pascal-fischer pascal-fischer merged commit 1a62394 into main Dec 30, 2024
29 checks passed
@pascal-fischer pascal-fischer deleted the fix/posture-checks-for-networks branch December 30, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants