Add handler chains #3039
Merged
Add handler chains #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixmal
force-pushed
the
dns-interceptor-handler-chain
branch
from
b70845f to
2ff4d54
Compare
lixmal
force-pushed
the
dns-interceptor-handler-chain
branch
from
2ff4d54 to
a671ba0
Compare
pappz
reviewed
Dec 12, 2024
| @@ -18,6 +20,7 @@ type DNSForwarder struct { | |||
| } | |||
|
|
|||
| func NewDNSForwarder(listenAddress string, ttl uint32, domains []string) *DNSForwarder { | |||
| log.Debugf("creating DNS forwarder with listen address: %s, ttl: %d, domains: %v", listenAddress, ttl, domains) | |||
There was a problem hiding this comment.
It is duplicated, we print the same info in manager.
pappz
approved these changes
Dec 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist