[client] Fix race condition with systray ready #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mohamed-essam
changed the title
braginini
approved these changes
Dec 14, 2024
braginini
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
fyne.io/systray package calls onTrayReady before fully initializing, causing some calls (e.g SetIcon) to fail silently because
propsglobal variable inside systray package is not yet set, while the MenuItems can be updated normally without failure.This causes netbird-ui icon to stay stuck on Disconnected if netbird service was running and connected before netbird-ui starts up.
This is mainly a workaround since the issue in systray is not responsive.
Issue ticket number and link
Checklist