Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management] Update account peers on login on meta change #2991

Merged
merged 2 commits into from
Dec 5, 2024
Merged

[management] Update account peers on login on meta change #2991

merged 2 commits into from
Dec 5, 2024

Conversation

mohamed-essam
Copy link
Contributor

@mohamed-essam mohamed-essam commented Dec 5, 2024 •
edited
Loading

Describe your changes

Replicate behavior in sync method regarding meta updates.

Issue ticket number and link

#1803

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mohamed-essam mohamed-essam mentioned this pull request Dec 5, 2024
Open
mlsmaycon
mlsmaycon approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mohamed-essam, great contribution

@mlsmaycon mlsmaycon merged commit 713e320 into netbirdio:main Dec 5, 2024
26 checks passed
@mlsmaycon mlsmaycon changed the title Update account peers on login on meta change [management] Update account peers on login on meta change Dec 5, 2024
@reginaldosoares reginaldosoares mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamed-essam @mlsmaycon