Add missing parentheses on iphone hostname generation condition #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Hi @jnohlgard, you are right, this will have no effect because when a peer doesn't have a userID the IdP lookup will fail and it will fallback to the default name anyway. Anyway, the code should reflect the proper intended behavior and not rely on the surrounding code to handle this. That was a very good catch! Thanks a lot for the fix. |
pascal-fischer
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add missing parentheses around the comparison to fill the hostname field from the IdP user data when using iphone.
Issue ticket number and link
No ticket. Found this apparent bug when browsing the code for something completely unrelated, I don't believe this will affect anything in real world usage.
Checklist