Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] Setup key improvements #2775

Merged
merged 14 commits into from
Oct 28, 2024
Merged

Conversation

pascal-fischer
Copy link
Contributor

@pascal-fischer pascal-fischer commented Oct 24, 2024

Describe your changes

This PR adds the following changes:

  • migrated setup keys from plain text to hashed format in the database
  • allows custom expiration time for setup keys. There is no limit anymore, it even allows not expiring keys
  • add delete endpoint for setup keys

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@pascal-fischer pascal-fischer marked this pull request as ready for review October 24, 2024 16:32
Copy link

@pascal-fischer pascal-fischer merged commit 10480eb into main Oct 28, 2024
21 checks passed
@pascal-fischer pascal-fischer deleted the feature/improve-setup-keys branch October 28, 2024 16:52
hurricanehrndz added a commit to hurricanehrndz/netbird that referenced this pull request Nov 5, 2024
…te_change

* upstream/main: (81 commits)
  Fix cached device flow oauth (netbirdio#2833)
  Avoid failing all other matrix tests if one fails (netbirdio#2839)
  add all group to add peer affected peers network map check (netbirdio#2830)
  [client] Log windows panics (netbirdio#2829)
  Fix unused servers cleanup (netbirdio#2826)
  [management] Add DB access duration to logs for context cancel (netbirdio#2781)
  Allocate new buffer for every package (netbirdio#2823)
  [client] Nil check on ICE remote conn (netbirdio#2806)
  [management] remove network map diff calculations (netbirdio#2820)
  Create FUNDING.yml (netbirdio#2814)
  Create funding.json (netbirdio#2813)
  [management] add metrics to network map diff (netbirdio#2811)
  [client] Fix the broken dependency gvisor.dev/gvisor (netbirdio#2789)
  fix meta is equal slices (netbirdio#2807)
  [client] Fix multiple peer name filtering in netbird status command (netbirdio#2798)
  [management] Setup key improvements (netbirdio#2775)
  [client] allow relay leader on iOS (netbirdio#2795)
  [client] Remove legacy forwarding rules in userspace mode (netbirdio#2782)
  [client] Ignore route rules with no sources instead of erroring out (netbirdio#2786)
  [misc] Update Zitadel from v2.54.10 to v2.64.1
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants