[client] Cleanup dns and route states on startup #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixmal
changed the title
pappz
reviewed
Oct 23, 2024
pappz
reviewed
Oct 23, 2024
|
|
||
| // State interface defines the methods that all state types must implement | ||
| type State interface { | ||
| Name() string |
There was a problem hiding this comment.
If accidentally implement multiple states with the same name then it can cause an issue. Maybe would be good to maintain the names in this pkg.
There was a problem hiding this comment.
I could add a check in RegisterState but that means we need to return an error which adds more refactoring/boilerplate. Is it worth it?
There was a problem hiding this comment.
I am just thinking in exported const string what will be used by the implementation of the interface.
|
pappz
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist