Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Support configurable max log size with var NB_LOG_MAX_SIZE_MB #2592

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

mlsmaycon
Copy link
Collaborator

Describe your changes

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon mlsmaycon changed the title Support configurable max log size with var NB_LOG_MAX_SIZE_MB [misc] Support configurable max log size with var NB_LOG_MAX_SIZE_MB Sep 12, 2024
Copy link

Copy link
Contributor

@mgarces mgarces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid to me, approved

@mlsmaycon mlsmaycon merged commit f6d57e7 into main Sep 12, 2024
21 checks passed
@mlsmaycon mlsmaycon deleted the configurable-max-log-size branch September 12, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants