Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DNS resolution for routes on iOS #2378

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

pascal-fischer
Copy link
Contributor

Describe your changes

When adding DNS routes that are only resolved by a private nameserver the resolution was failing. This PR uses the custom dailer form the dns package also in dns routes.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

client/internal/routemanager/dynamic/route_ios.go Outdated Show resolved Hide resolved
client/internal/routemanager/dynamic/route_ios.go Outdated Show resolved Hide resolved
client/internal/routemanager/dynamic/route_ios.go Outdated Show resolved Hide resolved
client/internal/routemanager/dynamic/route_ios.go Outdated Show resolved Hide resolved
client/internal/routemanager/dynamic/route.go Show resolved Hide resolved
lixmal
lixmal previously approved these changes Aug 2, 2024
lixmal
lixmal previously approved these changes Aug 2, 2024
Copy link

sonarqubecloud bot commented Aug 2, 2024

@pascal-fischer pascal-fischer merged commit 501fd93 into main Aug 2, 2024
20 of 22 checks passed
@pascal-fischer pascal-fischer deleted the fix/dns-route-resolution-for-private-dns branch August 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants