Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): freebsd should be red on error #2346

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

skillcoder
Copy link
Contributor

Describe your changes

  • Fix "green" failed FreeBSD tests
  • Disable setDefaultFonts on BSD systems in font_bsd.go, since we do not support UI on FreeBSD

Issue ticket number and link

No issue yet.
Here a problem description
Currently in the main branch FreeBSD test are failed, but github check Test Code FreeBSD / test (pull_request) is green.
This is current upstream main branch
https://github.com/skillcoder/netbird/actions/runs/10131717212/job/28014770728?pr=2

  # github.com/netbirdio/netbird/client/ui
  client/ui/font_bsd.go:14:10: undefined: serviceClient
  ?   	github.com/netbirdio/netbird/client/ui/config	[no test files]
  FAIL
  + cd client
  + go build .
  error obtaining VCS status: exit status 128
  	Use -buildvcs=false to disable VCS stamping.

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

Copy link
Contributor

@lixmal lixmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the client ui, see my comment #2309 (comment)

@skillcoder
Copy link
Contributor Author

skillcoder commented Jul 30, 2024

Regarding the client ui, see my comment #2309 (comment)

@lixmal Thank you for sharing this.

However, the mentioned PR does not fix the broken tests. Additionally, I don't think we need to support FreeBSD desktops, at least for now. If we do need it in the future, we should create a separate issue and add support in a separate PR.

@lixmal
Copy link
Contributor

lixmal commented Jul 30, 2024

Regarding the client ui, see my comment #2309 (comment)

@lixmal Thank you for sharing this.

However, the mentioned PR does not fix the broken tests. Additionally, I don't think we need to support FreeBSD desktops, at least for now. If we do need it in the future, we should create a separate issue and add support in a separate PR.

It doesn't fix the whole build, no, it fixes the issue with the build caused by missing code in the systray library. The referenced PR switches the library which fixes that part.

Once the other PR is merged, we can remove the build restrictions in https://github.com/netbirdio/netbird/blob/main/client/ui/client_ui.go#L1 and https://github.com/netbirdio/netbird/blob/main/client/ui/route.go#L1 to make the build/tests pass

@lixmal lixmal merged commit 9d2047a into netbirdio:main Jul 31, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants