-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): freebsd should be red on error #2346
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the client ui, see my comment #2309 (comment)
@lixmal Thank you for sharing this. However, the mentioned PR does not fix the broken tests. Additionally, I don't think we need to support FreeBSD desktops, at least for now. If we do need it in the future, we should create a separate issue and add support in a separate PR. |
It doesn't fix the whole build, no, it fixes the issue with the build caused by missing code in the systray library. The referenced PR switches the library which fixes that part. Once the other PR is merged, we can remove the build restrictions in https://github.com/netbirdio/netbird/blob/main/client/ui/client_ui.go#L1 and https://github.com/netbirdio/netbird/blob/main/client/ui/route.go#L1 to make the build/tests pass |
Describe your changes
font_bsd.go
, since we do not support UI on FreeBSDIssue ticket number and link
No issue yet.
Here a problem description
Currently in the
main
branch FreeBSD test are failed, but github checkTest Code FreeBSD / test (pull_request)
is green.This is current upstream
main
branchhttps://github.com/skillcoder/netbird/actions/runs/10131717212/job/28014770728?pr=2
Checklist