Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor login with store.SavePeer #2334

Merged
merged 7 commits into from
Jul 29, 2024
Merged

Conversation

mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Jul 26, 2024

Describe your changes

This pull request refactors the login functionality by integrating store.SavePeer. The changes aim to improve the handling of peer login processes, particularly focusing on synchronization and error handling.

Changes:

  • Refactored login logic to use store.SavePeer.
  • Added checks for login without lock for login necessary checks from the client and utilized write lock for full login flow.
  • Updated error handling with status.NewPeerLoginExpiredError().
  • Moved geoIP check logic to a more appropriate place.
  • Removed redundant calls and improved documentation.
  • Moved the code to smaller methods to improve readability.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

@mlsmaycon mlsmaycon marked this pull request as ready for review July 28, 2024 13:36
@mlsmaycon mlsmaycon merged commit da39c8b into main Jul 29, 2024
22 checks passed
@mlsmaycon mlsmaycon deleted the refactor/peer-login-account-handler branch July 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants