Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor macOS system DNS configuration #2284

Merged

Conversation

hurricanehrndz
Copy link
Contributor

On macOS use the recommended settings for providing split DNS. As per the docs an empty string will force the configuration to be the default. In order to to support split DNS an additional service config is added for the local server and search domain settings.

see: https://developer.apple.com/documentation/devicemanagement/vpn/dns

Describe your changes

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

On macOS use the recommended settings for providing split DNS. As per
the docs an empty string will force the configuration to be the default.
In order to to support split DNS an additional service config is added
for the local server and search domain settings.

see: https://developer.apple.com/documentation/devicemanagement/vpn/dns
@hurricanehrndz hurricanehrndz force-pushed the chernand/refactor_macos_split_dns branch from e61061a to bac8012 Compare July 17, 2024 18:42
@mlsmaycon
Copy link
Collaborator

Thanks for the contribution @hurricanehrndz, the configuration is much simpler now.

@mlsmaycon mlsmaycon merged commit ef1a39c into netbirdio:main Jul 18, 2024
21 checks passed
@hurricanehrndz hurricanehrndz deleted the chernand/refactor_macos_split_dns branch November 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants