Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): send logs to syslog #2259

Merged
merged 1 commit into from
Jul 16, 2024
Merged

feat(client): send logs to syslog #2259

merged 1 commit into from
Jul 16, 2024

Conversation

mrl5
Copy link
Contributor

@mrl5 mrl5 commented Jul 11, 2024

closes #2255

Describe your changes

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mrl5
Copy link
Contributor Author

mrl5 commented Jul 11, 2024

hey, go is not really "my thing" yet but I think this changes should do the trick. any suggestions from reviewers more than welcome

@mlsmaycon mlsmaycon requested a review from pappz July 11, 2024 16:46
@mrl5 mrl5 force-pushed the issue-2255 branch 2 times, most recently from 45a77d5 to 2ba4443 Compare July 11, 2024 17:58
mlsmaycon
mlsmaycon requested changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrl5 thanks for your PR. I left a request to handle windows build. After fixing that you can mark the PR as ready.

util/log.go Outdated Show resolved Hide resolved
@mrl5 mrl5 marked this pull request as ready for review July 15, 2024 15:23
@mrl5 mrl5 requested a review from mlsmaycon July 15, 2024 15:26
mlsmaycon
mlsmaycon approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your PR @mrl5

@mlsmaycon mlsmaycon merged commit 1d6f548 into netbirdio:main Jul 16, 2024
21 checks passed
@mrl5
Copy link
Contributor Author

mrl5 commented Jul 16, 2024

thanks for merging @mlsmaycon ! here is a follow-up PR that fixes some sonar qube issues #2276

@mrl5 mrl5 mentioned this pull request Jul 19, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

@pappz pappz Awaiting requested review from pappz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[question] linux client logs to syslog
3 participants
@mrl5 @CLAassistant @mlsmaycon