Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debounce network monitor restarts #2225

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Debounce network monitor restarts #2225

merged 2 commits into from
Jul 2, 2024

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Jul 1, 2024 •
edited
Loading

Describe your changes

This will debounce engine restarts triggered by the network monitor.
It will fix two issues:

  • potential races when (re)creating resources (like the wireguard interface) concurrently
  • constant restarts from ongoing network monitor events, e.g. by flapping interfaces on the system

Issue ticket number and link

#2196
#2130

Also see previous PR !2197

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@lixmal
Copy link
Contributor Author

lixmal commented Jul 1, 2024

@christian-schlichtherle @hurricanehrndz Please test

@mlsmaycon
Copy link
Collaborator

@christian-schlichtherle @hurricanehrndz this is the build link: https://github.com/netbirdio/netbird/actions/runs/9747549529/artifacts/1656256728

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mlsmaycon
Copy link
Collaborator

mlsmaycon commented Jul 2, 2024 •
edited
Loading

@christian-schlichtherle @hurricanehrndz latest build link: https://github.com/netbirdio/netbird/actions/runs/9760007485/artifacts/1659327748

@lixmal lixmal merged commit cea19de into main Jul 2, 2024
22 checks passed
@lixmal lixmal deleted the fix/prevent-multiple-monitor-restarts branch July 2, 2024 15:09
@hurricanehrndz hurricanehrndz mentioned this pull request Jul 3, 2024
Closed
lixmal added a commit that referenced this pull request Jul 22, 2024
@lixmal
Debounce network monitor restarts (#2225)
8e21ee4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lixmal @mlsmaycon