-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Use Zitadel Postgres Integration by default #2181
Feature/Use Zitadel Postgres Integration by default #2181
Conversation
Awesome PR, @r0b2g1t; thanks. We actually had in our roadmap to make Postgres the default for the installer. Can you update the following check to reflect that? if [[ $ZITADEL_DATABASE == "" ]]; then
CRDB=$(renderDockerComposeCockroachDB)
ZITADEL_DB_ENV=$(renderZidatelCockroachDBEnv)
elif [[ $DATABASE == "postgres" ]]; then
CRDB=$(renderDockerComposePostgres)
ZITADEL_DB_ENV=$(renderZidatelPostgresEnv)
fi |
@mlsmaycon thanks for the remark. I have set Postgres as default and added echos for the user about the usage of the environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @r0b2g1t .
Can you also update the https://github.com/netbirdio/netbird/blob/main/.github/workflows/test-infrastructure-files.yml#L172 file with cockroachdb tests?
I will take a look into it and will try to create tests. 🙂 |
@mlsmaycon I have added tests for psotgres and cockroach. |
@mlsmaycon the tests are stable. May you can take a look into it and give feedback. |
@r0b2g1t thanks again for the amazing contribution |
replaces cockroachDB as default DB for Zitadel in the getting started script to deploy script. Users can switch back to cockroachDB by setting the environment variable ZITADEL_DATABASE to cockroach.
This PR replaces cockroachDB as default DB for Zitadel in the getting started script to deploy script. Users can switch back to cockroachDB by setting the environment variable
ZITADEL_DATABASE
tocockroach
.The PR fix some typos as well.
Issue ticket number and link
Checklist