-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNS routes #1943
Merged
Merged
Add DNS routes #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Open
Not digging into the details (maybe it's here), but it's worth watching out for resolving DNS names on the Peer doing the routing from within the network. |
lixmal
force-pushed
the
feature/dns-routes
branch
from
May 31, 2024 11:56
b5b12b0
to
b5912ce
Compare
pappz
reviewed
Jun 3, 2024
lixmal
force-pushed
the
feature/dns-routes
branch
from
June 3, 2024 12:41
81b93e2
to
129f515
Compare
Quality Gate passedIssues Measures |
pappz
approved these changes
Jun 4, 2024
mlsmaycon
added a commit
that referenced
this pull request
Jun 13, 2024
* compile client under freebsd (#1620) Compile netbird client under freebsd and now support netstack and userspace modes. Refactoring linux specific code to share same code with FreeBSD, move to *_unix.go files. Not implemented yet: Kernel mode not supported DNS probably does not work yet Routing also probably does not work yet SSH support did not tested yet Lack of test environment for freebsd (dedicated VM for github runners under FreeBSD required) Lack of tests for freebsd specific code info reporting need to review and also implement, for example OS reported as GENERIC instead of FreeBSD (lack of FreeBSD icon in management interface) Lack of proper client setup under FreeBSD Lack of FreeBSD port/package * Add DNS routes (#1943) Given domains are resolved periodically and resolved IPs are replaced with the new ones. Unless the flag keep_route is set to true, then only new ones are added. This option is helpful if there are long-running connections that might still point to old IP addresses from changed DNS records. * Add process posture check (#1693) Introduces a process posture check to validate the existence and active status of specific binaries on peer systems. The check ensures that files are present at specified paths, and that corresponding processes are running. This check supports Linux, Windows, and macOS systems. Co-authored-by: Evgenii <[email protected]> Co-authored-by: Pascal Fischer <[email protected]> Co-authored-by: Zoltan Papp <[email protected]> Co-authored-by: Viktor Liu <[email protected]> Co-authored-by: Bethuel Mmbaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds DNS routes.
Given domains are resolved periodically and resolved IPs are replaced with the new ones. Unless the flag
keep_route
is set totrue
, then only new ones are added.This option is helpful if there are long-running connections that might still point to old IP addresses from changed DNS records.
This feature is not yet ready to catch changes from resolvers that use round-robin DNS.
Example route creation
Viewing resolved IPs
Currently resolved IPs can be viewed by running
netbird routes ls
Example output:
Status
Routes can be tracked via
netbird status -d
as usual:On the client:
On the routing peer:
Issue ticket number and link
Checklist