-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support to configure extra blacklist of iface in "up" command #1734
Conversation
Hey @hoozecn I think that this will only work in the foreground mode, which is mostly used only in Docker. A more traditional way is to use a dameon mode. The cmd communicates with a local dameon service through gRPC. |
Yes. we use netbird client as Daemonset in Kubernetes so that the selected nodes will work as gateways of the cluster. the change in PR is enough for us and works well. For your point, I'm happy to see to make it be configurable too in traditional way when we run But before that, do you think it worth a try? |
I will sync with the team tomorrow morning and get back to you after. Thank you! |
becb046
to
857b270
Compare
@braginini hey man, thanks for you sync. I have update the pr to support the daemon mode. Just find another PR not merged #1586. Seems it's going to support to configure InterfaceBlacklist too. The ExtraIFaceBlacklist option make help people avoid to provide the default blacklist in the command line. But use InterfaceBlacklist will be more explicit. Which do you think is better? |
…dio#1734) Support to configure extra blacklist of iface in "up" command
Describe your changes
we can configure extra blacklist of iface in "up" command instead of editing config file
Issue ticket number and link
Checklist