-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The single quote breaks the strings in Android. We should escape them #88
base: master
Are you sure you want to change the base?
The single quote breaks the strings in Android. We should escape them #88
Conversation
@@ -16,7 +16,8 @@ def language_filepaths(language) | |||
|
|||
def process_value(row_value, default_value) | |||
value = super(row_value, default_value) | |||
# if the value begins and ends with a quote we must leave them unescapted | |||
value.gsub!(/'/, {"'" => "\\'"}) # escape single quote only for Android |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant curly braces around a hash parameter.
Space inside { missing.
Space inside } missing.
Changes Unknown when pulling 95ba087 on ctarabusi:fix-android-single-quote-escaping into * on netbe:master*. |
Changes Unknown when pulling bc97884 on ctarabusi:fix-android-single-quote-escaping into * on netbe:master*. |
@ctarabusi sure just check the unit tests on travis, they are not passing right now. |
Hey @ctarabusi, please rebase with master and fix tests:
|
@ctarabusi any interest in finishing/commenting on the state of this? |
Hi Francois,
I hope you are well, would you care to review this PR and eventually merge it?