feat(): Add support for [email protected] literal repositories #383

[matomesc]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #383

What is the new behavior?

Check if Repository is a function to determine if [email protected] is being used and if so then use the literal repository object to generate repository injection token.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Tests are passing for current [email protected] but failing for [email protected] due to Repository no longer being a function. The custom repository also needs to be refactored: https://github.com/nestjs/typeorm/blob/master/tests/src/photo/photo.repository.ts#L5

[kamilmysliwiec]

Btw what about custom repositories in 0.3.0. Are they going to be deprecated/removed?

[matomesc]

You can extend a repository with custom methods by calling extend() on a repository instance:

repository.extend({
  customMethod() {
     // ...
  }
});

https://github.com/typeorm/typeorm/blob/b177e230a6fcb11f1eb71d4d431d0297436b7f6f/src/repository/Repository.ts#L380

[micalevisk]

@kamilmysliwiec now (0.3.0) @EntityRepository() is deprecated. Here's how we should use instead: https://github.com/typeorm/typeorm/blob/master/docs/custom-repository.md

[kamilmysliwiec]

This PR is 2 years old so it may contain outdated code. Let me just close it and create a new one for migrating to the latest version of TypeORM

[derekcunningham-ab]

This PR is 2 years old so it may contain outdated code. Let me just close it and create a new one for migrating to the latest version of TypeORM

@kamilmysliwiec Any luck with this? I'm starting a new project, and if NestJS is on the precipice of migrating, I'd rather commit to the latest version of TypeORM over using outdated approaches.

[kamilmysliwiec]

I've started 10 days ago and I noticed that TypeORM Readme & docs were still not even updated to the latest version so I figured I'll have to wait at least a few days more before I can jump onto this issue.

[lovetodream]

This PR is 2 years old so it may contain outdated code. Let me just close it and create a new one for migrating to the latest version of TypeORM

@kamilmysliwiec Any luck with this? I'm starting a new project, and if NestJS is on the precipice of migrating, I'd rather commit to the latest version of TypeORM over using outdated approaches.

@derekcunningham-ab I've created a fork for myself, which seems to work fine as a temporary solution. Maybe you can use it until the official nestjs module is updated, if you don't want to wait.

[EdouardBougon]

It seems that the documentation is now updated

[bviala]

bump

[jmcdo29]

#1233