feat: graceful shutdown timeout #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set default option to 0ms Related issue: nestjs#2421
Lp-Francois
changed the title
BrunnerLivio
requested changes
Nov 23, 2023
lib/graceful-shutdown-timeout/graceful-shutdown-timeout.service.ts
Outdated
Show resolved
Hide resolved
lib/graceful-shutdown-timeout/graceful-shutdown-timeout.service.ts
Outdated
Show resolved
Hide resolved
|
Thanks a lot @Lp-Francois well done! |
Co-authored-by: Livio Brunner <[email protected]>
Suggestion from @BrunnerLivio during PR review Co-authored-by: Livio Brunner <[email protected]>
Suggestion from @BrunnerLivio during PR review Co-authored-by: Livio Brunner <[email protected]>
Suggestion from @BrunnerLivio during PR review Co-authored-by: Livio Brunner <[email protected]>
…rvice Suggestion from @BrunnerLivio during PR review Co-authored-by: Livio Brunner <[email protected]>
Suggestion from @BrunnerLivio during PR review
|
Requested changes done ✅ @BrunnerLivio |
Tony133
reviewed
Nov 24, 2023
BrunnerLivio
approved these changes
Nov 26, 2023
|
Great job, about to release this! |
|
Nice thanks ✌️ |
1 task
10 tasks
|
Moved the documentation from the README.md to the NestJS docs. |
rvitaliy
reviewed
Nov 27, 2023
| this.logger.log( | ||
| `Awaiting ${this.gracefulShutdownTimeoutMs}ms before shutdown`, | ||
| ); | ||
| await sleep(this.gracefulShutdownTimeoutMs); |
There was a problem hiding this comment.
@BrunnerLivio you can just:
import { setTimeout } from 'node:timers/promises';
await setTimeout(this.gracefulShutdownTimeoutMs);
see: https://nodejs.org/api/timers.html#timerspromisessettimeoutdelay-value-options
There was a problem hiding this comment.
@BrunnerLivio sorry, wrong mention... the author of the PR is @Lp-Francois
There was a problem hiding this comment.
TIL, didn't know this API exist :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2421
What is the new behavior?
Add a new option
gracefulShutdownTimeoutMsthat adds a delay to the application shutdown if specified.Does this PR introduce a breaking change?
Other information