-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): fix multiple document not working when using fastify #427
Conversation
see fastify/fastify-swagger#216 (review) |
mode: 'static', | ||
specification: { | ||
document | ||
httpServer.register(async (httpServer: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently fastify plugin works differently. Per its documentation, this adds a different scope so the internal call
fastify.decorate('swagger', swagger)
does not collide when we try to make multiple swagger docs
Can you create an integration test for this change too? |
@kamilmysliwiec Done! |
@kamilmysliwiec can you clean this up and merge this? I really want this for my project, thanks! |
Thank you @Boshen! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes #234
fixes fastify/fastify-swagger#213
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information