Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): fix multiple document not working when using fastify #427

Merged
merged 2 commits into from
Dec 27, 2019
Merged

fix(): fix multiple document not working when using fastify #427

merged 2 commits into from
Dec 27, 2019

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Dec 10, 2019

fixes #234
fixes fastify/fastify-swagger#213

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[*] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[*] No

Other information

@Boshen
Copy link
Contributor Author

Boshen commented Dec 10, 2019

see fastify/fastify-swagger#216 (review)
I've tested it in my own project

mode: 'static',
specification: {
document
httpServer.register(async (httpServer: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently fastify plugin works differently. Per its documentation, this adds a different scope so the internal call
fastify.decorate('swagger', swagger) does not collide when we try to make multiple swagger docs

@kamilmysliwiec
Copy link
Member

Can you create an integration test for this change too?

@Boshen
Copy link
Contributor Author

Boshen commented Dec 11, 2019

Can you create an integration test for this change too?

@kamilmysliwiec Done!

@Boshen
Copy link
Contributor Author

Boshen commented Dec 13, 2019

@kamilmysliwiec can you clean this up and merge this? I really want this for my project, thanks!

@kamilmysliwiec kamilmysliwiec merged commit bdf5d78 into nestjs:master Dec 27, 2019
@kamilmysliwiec
Copy link
Member

Thank you @Boshen!

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic decorator name Swagger multiple document not working when use Nestjs Fastify
3 participants