Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sample): id param is string type #9597

Merged
merged 1 commit into from
May 31, 2022
Merged

fix(sample): id param is string type #9597

merged 1 commit into from
May 31, 2022

Conversation

yiminghe
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Fix sample

What is the current behavior?

graphql federation sample does not work when query

{
  post(id: 1) {
    id
    user {
      name
    }
  }
}

What is the new behavior?

graphql federation works

Does this PR introduce a breaking change?

  • Yes
  • No

@yiminghe yiminghe changed the title fix: id param is string type fix(sample): id param is string type May 18, 2022
@coveralls
Copy link

coveralls commented May 18, 2022

Pull Request Test Coverage Report for Build 8688c944-9aa0-4124-871d-b43a4b378818

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 94.113%

Files with Coverage Reduction New Missed Lines %
packages/microservices/client/client-kafka.ts 5 95.63%
packages/core/router/router-explorer.ts 7 82.76%
Totals Coverage Status
Change from base Build 2b04a680-b795-4096-8781-3ac877ccaade: 0.006%
Covered Lines: 5771
Relevant Lines: 6132

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 404efbb into nestjs:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants