Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): multiple rmq client urls issue #9364 #9425

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #9364

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5d58a3c2-559e-4daa-a51b-96aa5d515156

  • 1 of 7 (14.29%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 94.043%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/client/client-rmq.ts 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
packages/microservices/client/client-rmq.ts 1 81.13%
Totals Coverage Status
Change from base Build 73a19d9e-28f7-4c3e-bdf0-1ec3a42dbc33: -0.08%
Covered Lines: 5762
Relevant Lines: 6127

💛 - Coveralls

Copy link

@rheh rheh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 45872ae into master Apr 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/multiple-rmq-client-urls branch April 7, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants