-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(): remove duplicate function getClassScope
#8800
refactor(): remove duplicate function getClassScope
#8800
Conversation
Pull Request Test Coverage Report for Build 9229029f-6efc-4ed1-9dc4-37cf04265af3
💛 - Coveralls |
I want to move export function setClassScope(provider: Type<unknown>, scope: Scope): void {
Reflect.defineMetadata(SCOPE_OPTIONS_METADATA, scope, provider);
} I think get and set should be a pair. And alse easy to write unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good @zanminkian! |
@kamilmysliwiec Could you please review this PR? I will create a next PR to optimize class scope management. |
e909ef6
to
bc8b9e8
Compare
lgtm |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information