-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): ParseUUIDPipe - throw exceptions with exceptionFactory only #8459
Conversation
Pull Request Test Coverage Report for Build 37fe1162-b766-4cd0-9a52-bed710d01bc1
💛 - Coveralls |
We can keep original message and use exceptionFactory to throw correct exception when str is not string (not sure if it's needed). To do so we can remove the util (it's used only in the pipe) and move its code to the pipe file. |
55daba1
to
ed7875c
Compare
Done |
fa515c2
to
8b7d3f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8b7d3f0
to
9c0cdd2
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ParseUUIDPipe
supportsexceptionFactory
option. But when it validates not a string,exceptionFactory
is ignored andBadRequestException
is thrown fromisUUID
utilWhat is the new behavior?
isUUID
util does not throw an Exception and delegates the decision toParseUUIDPipe
Does this PR introduce a breaking change?
Other information