Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform #7293

Closed
wants to merge 2 commits into from
Closed

Transform #7293

wants to merge 2 commits into from

Conversation

DenisVASI9
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[*] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Using toPromise does not allow you to use BehavourSubject, although its interface has a subscribe method.
For example:

  @Get()
  test() {
    const bs = new BehaviorSubject({state: 'some state'})
    return bs;
  }

Does this PR introduce a breaking change?

[ ] Yes
[*] No

Other information

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a change to the integration tests to show that this works as expected?

@DenisVASI9
Copy link
Author

Okay, I'll try to do that.

@kamilmysliwiec
Copy link
Member

This will change in this PR #6349 (it updates to the latest version of RxJS and no longer uses .toPromise() in the codebase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants