-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): built-in, console logger refactor #6221
Conversation
Pull Request Test Coverage Report for Build 167df087-dfd3-42eb-87d6-1ca378e36927
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is going to be incredibly helpful to so many! Quick question about what would happen, I think I know, but want to make sure,
Say that I want to use my custom logger, so I set bufferLogs
to true and will call app.useLogger(customLoggerInstance)
later on. If there is an error, such as Nest not being able to resolve a dependency, because app.useLogger
hasn't been called yet, it will use Nest's default ConsoleLogger
to print the error, correct?
Correct :) |
Late to the party but thanks for these improvements @kamilmysliwiec! This looks badass |
Hi I don't know if it's related to this We fixed the tests adding
thanks :) |
@jjchiw make sure you're using |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
#6142
#6172
#5353
and a few others.
What is the new behavior?
Logger
wrapper class andConsoleLogger
classDoes this PR introduce a breaking change?
Other information