Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add RouterModule (e.g., for versioning) #6035

Merged
merged 7 commits into from
Jan 27, 2021

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 97f1bc4e-4f6d-4bee-9541-5896b87221c0

  • 76 of 83 (91.57%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 94.68%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/middleware/routes-mapper.ts 20 27 74.07%
Totals Coverage Status
Change from base Build ba2889c0-ee13-4278-a9af-fba2d8785eb1: -0.06%
Covered Lines: 5143
Relevant Lines: 5432

💛 - Coveralls

package.json Outdated Show resolved Hide resolved
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 8.0.0 January 27, 2021 11:13
@kamilmysliwiec kamilmysliwiec merged commit 1320f4e into 8.0.0 Jan 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/router-module branch January 27, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants