feat(core): base exception filter supports the http-errors library #5990
+813
−363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2020
kamilmysliwiec
changed the title
Pull Request Test Coverage Report for Build 232f0823-17a3-4e83-bf5f-7563dfb0013d
💛 - Coveralls |
kamilmysliwiec
changed the title
|
@kamilmysliwiec is there anything I can do to help get this going? |
bilalshaikh42
added a commit
to biosimulations/biosimulations
that referenced
this pull request
Oct 21, 2021
due to an issue with nestjs not processing payload too large errors properly, such errors were returned as 500. This adds a check in the default filter to account for this case See nestjs/nest#5990. Co-authored-by: Jonathan Karr <[email protected]> closes #3349
biosimulations-daemon
added a commit
to biosimulations/biosimulations
that referenced
this pull request
Oct 24, 2021
# [5.9.0](v5.8.0...v5.9.0) (2021-10-24) ### Bug Fixes * **deps:** update to nx v13 ([48dbf7c](48dbf7c)) * **exceptions:** handle cases of payload too large errors ([522cec8](522cec8)), closes [nestjs/nest#5990](nestjs/nest#5990) [#3349](#3349) * **exceptions:** improve error handling ([083091e](083091e)) ### Features * **api:** add caching to results and ontology endpoints ([bb2a991](bb2a991)) * **api:** add caching to results endpoints ([ed54363](ed54363)) * **api:** add health check for job queue ([a05556e](a05556e)) * **api:** add health module and endpoints ([da036f5](da036f5)) * **api:** add various health checks and endpoints ([d30c7d2](d30c7d2)) * **api:** setup results cache with REDIS ([3e40fde](3e40fde)) * **dispatch-service:** add limit for retries of status for jobs ([f187b03](f187b03)) * **dispatch,platform:** added structured data for projects, simulation runs: ([7135ed0](7135ed0)) * **dispatch,simulators:** added structured data tutorials ([5c23e8d](5c23e8d)) * **dispatch,simulators:** encoded FAQs into Schema.org ([936fb44](936fb44)) * **exceptions:** dont process health check http exceptions ([b75747e](b75747e)) * **simulators-api,api:** added clearer payload too large messages ([98fb49d](98fb49d)) * **simulators-api:** add health checks for simulators-api ([26d3b63](26d3b63)) * **simulators:** added structured data for simulators as software applications ([7618db3](7618db3)) ### Reverts * **simulators-api,api:** revert partially the changes in 98fb49d ([d88fcea](d88fcea))
|
Has this issue been introduced again somewhere. Seems I'm hitting the same error with Nest/common v8.2.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
BaseExceptionFiltersupports the http-errors errors.Does this PR introduce a breaking change?
Other information