fix(): use class reference as injection token #5619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For class providers use a class reference instead of a class name as an injection token to address dependency injection conflicts when two classes share the same name. resolve #5591
Pull Request Test Coverage Report for Build 33f7de29-66df-40d2-aa8c-e9db09bbccf1
💛 - Coveralls |
galesky
reviewed
Oct 28, 2020
| metatype: DependencyTwo, | ||
| instance: Object.create(DependencyOne.prototype), | ||
| isResolved: false, | ||
| }); | ||
| moduleDeps.providers.set('MainTest', mainTest); | ||
| moduleDeps.providers.set('DependencyOne', depOne); | ||
| moduleDeps.providers.set('DependencyTwo', depTwo); | ||
| moduleDeps.providers.set(DependencyOne, depOne); |
There was a problem hiding this comment.
Not sure about changing that test though
Shouldn't you keep it (as strings are still valid names) and add a new one that uses Functions ?
There was a problem hiding this comment.
I think you're right. I'll update the PR when will get a chance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For class providers use a class reference instead of a class name as an injection token to address dependency injection conflicts when two classes share the same name.
resolve #5591
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #5591
What is the new behavior?
Does this PR introduce a breaking change?
Other information
N/A