fix(common): enforce string type in validationpipe #14241
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strictly parse the value to string to avoid nested objects being passed if the type is explicitly set to string closes nestjs#14234
Pull Request Test Coverage Report for Build 235ee298-c027-4827-8b3d-0f52882777ecDetails
💛 - Coveralls |
15 tasks
| @@ -207,6 +207,9 @@ export class ValidationPipe implements PipeTransform<any> { | |||
| return +value; | |||
| } | |||
| if (metatype === String) { | |||
There was a problem hiding this comment.
Suggested change
| if (metatype === String) { | |
| if (metatype === String && !isUndefined(value)) { |
| @@ -207,6 +207,9 @@ export class ValidationPipe implements PipeTransform<any> { | |||
| return +value; | |||
| } | |||
| if (metatype === String) { | |||
| if (isUndefined(value)) { | |||
There was a problem hiding this comment.
this nested if can be removed then
There was a problem hiding this comment.
I did this for sake of consistency, but changed it to the suggested implementation
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strictly parse the value to string to avoid nested objects being passed if the type is explicitly set to string.
The solution was already provided in the issue, I thought I could quickly submit a PR :) , however I didnt include the part for empty value, because if the value is set to string type and an empty value is provided, it should just return an empty string, it will be useful in some cases.
closes #14234
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The pipeline doesnt pass the value to string if an nested object is provided and the type is explicitly set to string.
Issue Number: #14234
What is the new behavior?
if the value of foo query set to string, it will parse it to string no matter the value.
Does this PR introduce a breaking change?
Other information