fix(websockets): Prevent HTTP server early close in Socket.IO shutdown #14185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1f935bcf-2e20-49d2-8b77-6a4688c12cf5Details
💛 - Coveralls |
|
LGTM |
| @@ -35,6 +40,9 @@ export abstract class AbstractWsAdapter< | |||
| } | |||
|
|
|||
| public async close(server: TServer) { | |||
| if (this._forceCloseConnections) { | |||
| return; | |||
| } | |||
There was a problem hiding this comment.
@sapenlei I just realized that this method should be called no matter the _forceCloseConnections for non-shared WS servers. This doesn't seem to be the case atm
There was a problem hiding this comment.
Even for non-shared ws servers, their connections are destroyed and the final shutdown is closed by express
There was a problem hiding this comment.
How come? What if you use a port different from the HTTP application?
There was a problem hiding this comment.
Sorry, there's a problem. I'll fix it tomorrow
There was a problem hiding this comment.
@kamilmysliwiec I fixed it #14204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13910
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #13910
What is the new behavior?
When ws connections and other long-running connections are handled by the same HTTP server instance, the shutdown process will not be blocked, allowing for proper termination of all connection types.
Does this PR introduce a breaking change?
Other information