Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): fix stacktrace regex #13317

Merged
merged 1 commit into from
Mar 17, 2024
Merged

fix(common): fix stacktrace regex #13317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/common/services/console-logger.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ export class ConsoleLogger implements LoggerService {
return false;
}

return /^(.)+\n\s+at .+:\d+:\d+$/.test(stack);
return /^(.)+\n\s+at .+:\d+:\d+/.test(stack);
Copy link
Contributor Author

@hokaccha hokaccha Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual string of stacktrace does not end with a number.

Error: err!
    at bootstrap (/path/to/src/main.ts:30:15)

}

private getColorByLogLevel(level: LogLevel) {
Expand Down
2 changes: 1 addition & 1 deletion packages/common/test/services/logger.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ describe('Logger', () => {

it('should print one error to the console with stacktrace', () => {
const message = 'random error';
const stacktrace = 'Error: message\n at <anonymous>:1:2';
const stacktrace = new Error('err').stack;

logger.error(message, stacktrace);

Expand Down