Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): when the discoverable decorator was not used on calling getProviders/getControllers #12519

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Oct 6, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #12518

What is the new behavior?

returns an empty Set - a null object, kinda (although I dislike the ideia of initializing a new empty object every time)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Oct 6, 2023

Pull Request Test Coverage Report for Build 054f6b66-c7e5-4b28-8e5c-22ef6ec99c67

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.639%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/discovery/discoverable-meta-host-collection.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 79434c05-5367-4a7a-a04c-0f91cc807577: 0.0%
Covered Lines: 6469
Relevant Lines: 6983

💛 - Coveralls

@micalevisk micalevisk changed the title fix(core): when the discoverable decorator is not used on calling getProviders/getControllers fix(core): when the discoverable decorator was not used on calling getProviders/getControllers Oct 7, 2023
@kamilmysliwiec kamilmysliwiec merged commit 551d12b into nestjs:master Oct 23, 2023
4 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

@micalevisk micalevisk deleted the fix/issue-12518 branch October 23, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiscoveryService's getProviders and getControllers fail when metadata key is not applied at least once
3 participants