Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): rmq should gracefully reconnect upon error #11019

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #10562

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build f7d53b20-5472-496d-a786-054887da2978

  • 18 of 22 (81.82%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 92.992%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/client/client-rmq.ts 18 22 81.82%
Files with Coverage Reduction New Missed Lines %
packages/microservices/client/client-rmq.ts 1 81.92%
packages/microservices/server/server-nats.ts 4 88.07%
Totals Coverage Status
Change from base Build ea25dfd5-fe51-42ae-b629-23996be1b77a: 0.03%
Covered Lines: 6383
Relevant Lines: 6864

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 2ed509a into master Feb 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/gracefully-reconnect-rmq branch February 2, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants