Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): use switch case for types of statuses in server #11001

Merged

Conversation

bittlerr
Copy link
Contributor

@bittlerr bittlerr commented Feb 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

The debug message of nats server appears even if debug mode is false, it seems that was fixed only on client side, not server one.
DEBUG [Server] NatsStatus: type: "pingTimer", data: "1".

Issue Number: 10783

What is the new behavior?

I filter out message if debug mode is false.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 742cca57-b5d5-4662-a650-264f5423af0b

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 92.959%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/server/server-nats.ts 5 8 62.5%
Totals Coverage Status
Change from base Build a491a671-3dc9-4afe-b7e0-675925f5f9aa: -0.03%
Covered Lines: 6377
Relevant Lines: 6860

💛 - Coveralls

@micalevisk
Copy link
Member

so this is a fix rather than a refactor, right?

could you please retitle your PR (for changelog sake)

@kamilmysliwiec
Copy link
Member

lgtm

@kamilmysliwiec kamilmysliwiec merged commit 664510a into nestjs:master Feb 2, 2023
@bittlerr bittlerr changed the title refactor(microservices): use switch case for types of statuses in server fix(microservices): use switch case for types of statuses in server Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants