-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/8844 api version in route info #10484
Merged
kamilmysliwiec
merged 11 commits into
nestjs:master
from
thiagomini:feature/8844-api-version-in-route-info
Nov 7, 2022
Merged
Feature/8844 api version in route info #10484
kamilmysliwiec
merged 11 commits into
nestjs:master
from
thiagomini:feature/8844-api-version-in-route-info
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure routes mapper returns route's version when defined
ensure routes mapper returns route's version when defined
ensure middleware builder gets route version
ensure middleware module considers path-versioning when applying middlewares
thiagomini
commented
Oct 31, 2022
method: defaultRequestMethod, | ||
}, | ||
]; | ||
return this.getRouteInfoFromPath(route); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I extracted many logic branches here to private methods to improve the public method's readability.
Pull Request Test Coverage Report for Build c8bde737-3fac-4677-8237-7ef34ba51ed0
💛 - Coveralls |
wrap test case for uri versioning context to facilitate the addition of tests for other versioning types
fix middlewares for versioned routes using header as versioning type
fix middlewares for versioned routes using media type as versioning type
refactor middleware tests to explicitly define versioning options
add middleware versionig support for uri versioning with an alternative prefix
add missing parameter to middleware module
LGTM |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Routes middleware aren't applied to versioned routes when using uri-versioning-type.
Issue Number: #8844
What is the new behavior?
middlewares can be applied to versioned routes with the following API:
Does this PR introduce a breaking change?
Other information