Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RabbitMQ connection options #13071

Closed
1 task done
tetofonta opened this issue Jan 19, 2024 · 3 comments · Fixed by #13105
Closed
1 task done

Add RabbitMQ connection options #13071

tetofonta opened this issue Jan 19, 2024 · 3 comments · Fixed by #13105

Comments

@tetofonta
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

The RabbitMQ microservice client allows only the property relative to socket options to the underlying ampqlib as per line client/client-rmq.ts:136. There is no way to pass additional connection options like ssl certificates and client certificates or to specify a different authentication method like EXTERNAL.

Describe the solution you'd like

Add a key to RmqOptions or substitue RmqOptions#socketOptions with the full options object

Teachability, documentation, adoption, migration strategy

External Authentication method: Here
amqplib ssl example passing certificates to the connect handler: Here
amqplib ssl EXTERNAL auth example: Here
ampqlib EXTERNAL auth method issue: Here

What is the motivation / use case for changing the behavior?

Impossibility of integrating RabbitMQ inside an existing microservice architecture because RabbitMQ is configured with mTLS authentication.

@tetofonta tetofonta added needs triage This issue has not been looked into type: enhancement 🐺 labels Jan 19, 2024
@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this issue?

@micalevisk micalevisk removed the needs triage This issue has not been looked into label Jan 19, 2024
Deniks added a commit to Deniks/nest that referenced this issue Jan 27, 2024
change socketOptions type from custom AmqpConnectionManagerSocketOptions to amqp-manager's AmqpConnectionOptions which allows to specify not only mTLS but also External auth

Closes nestjs#13071
Deniks added a commit to Deniks/nest that referenced this issue Jan 27, 2024
change socketOptions.connectionOptions type from any to amqp-manager's AmqpConnectionOptions which allows to specify not only mTLS but also External auth

Closes nestjs#13071
@Deniks
Copy link
Contributor

Deniks commented Jan 27, 2024

Hey, i have created PR for this issue.

@kamilmysliwiec
Copy link
Member

let's track this here #13105

Deniks added a commit to Deniks/nest that referenced this issue Jan 31, 2024
change socketOptions.connectionOptions type from any to copied amqp-manager's AmqpConnectionOptions

Closes nestjs#13071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants