Merge pull request #4213 from nestjs/fix/grpc-streaming-metadata

fix(microservices): fix sending metadata with grpc streaming
nestjs · Mar 3, 2020 · 5f95dbd · 5f95dbd
2 parents 1a805ad + ee55ceb
commit 5f95dbd
Showing 1 changed file with 17 additions and 8 deletions.
diff --git a/packages/microservices/client/client-grpc.ts b/packages/microservices/client/client-grpc.ts
@@ -153,12 +153,14 @@ export class ClientGrpcProxy extends ClientProxy implements ClientGrpc {
         let upstreamSubscription: Subscription;
 
         const upstreamSubjectOrData = args[0];
+        const maybeMetadata = args[1];
+
         const isUpstreamSubject =
           upstreamSubjectOrData && isFunction(upstreamSubjectOrData.subscribe);
 
         const call =
           isRequestStream && isUpstreamSubject
-            ? client[methodName]()
+            ? client[methodName](maybeMetadata)
             : client[methodName](...args);
 
         if (isRequestStream && isUpstreamSubject) {
@@ -215,13 +217,20 @@ export class ClientGrpcProxy extends ClientProxy implements ClientGrpc {
 
       if (isRequestStream && isUpstreamSubject) {
         return new Observable(observer => {
-          const call = client[methodName]((error, data) => {
-            if (error) {
-              return observer.error(error);
-            }
-            observer.next(data);
-            observer.complete();
-          });
+          const callArgs = [
+            (error: unknown, data: unknown) => {
+              if (error) {
+                return observer.error(error);
+              }
+              observer.next(data);
+              observer.complete();
+            },
+          ];
+          const maybeMetadata = args[1];
+          if (maybeMetadata) {
+            callArgs.unshift(maybeMetadata);
+          }
+          const call = client[methodName](...callArgs);
           upstreamSubjectOrData.subscribe(
             (val: unknown) => call.write(val),
             (err: unknown) => call.emit('error', err),