Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(authentication) URL and type fix #552

Merged
merged 1 commit into from
Jul 30, 2019
Merged

docs(authentication) URL and type fix #552

merged 1 commit into from
Jul 30, 2019

Conversation

evdhiggins
Copy link
Contributor

Update the link to the exception filters docs page and fix return type in one of the examples.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Documentation

What is the current behavior?

N/A

Issue Number: N/A

What is the new behavior?

N/A

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Update exception filter docs link and fix return type in example
Copy link
Member

@johnbiundo johnbiundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evdhiggins Thanks for this!

The sample code matches this change (returning promise), so this brings the docs in alignment with the sample.

@kamilmysliwiec - good to go.

@kamilmysliwiec kamilmysliwiec merged commit 2ef4f4a into nestjs:master Jul 30, 2019
duard pushed a commit to duard/docs.nestjs.com that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants