Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs (microservices): add documentation for KafkaContext.heartbeat usage #2409

Merged
merged 10 commits into from
Jul 21, 2022
Merged

docs (microservices): add documentation for KafkaContext.heartbeat usage #2409

merged 10 commits into from
Jul 21, 2022

Conversation

kosh-b
Copy link
Contributor

@kosh-b kosh-b commented Jul 19, 2022 •
edited
Loading

Add documentation of KafkaContext.heartbeat usage, related to: nestjs/nest#9954

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Issue Number: 9949 (of nestjs itself)

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kosh-b kosh-b mentioned this pull request Jul 19, 2022
Merged
12 tasks
jmcdo29
jmcdo29 suggested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight suggestion to grammar. Otherwise looks good

content/microservices/kafka.md Outdated Show resolved Hide resolved
@kosh-b @jmcdo29
Update content/microservices/kafka.md
879ab61 
Grammer fixes

Co-authored-by: Jay McDoniel <[email protected]>
@kosh-b
Copy link
Contributor Author

kosh-b commented Jul 20, 2022

Committed the suggestion:)

@kamilmysliwiec kamilmysliwiec merged commit 818c543 into nestjs:master Jul 21, 2022
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilmysliwiec kamilmysliwiec kamilmysliwiec left review comments

@jmcdo29 jmcdo29 jmcdo29 requested changes

@Tony133 Tony133 Tony133 approved these changes

Assignees

@kamilmysliwiec kamilmysliwiec

@jmcdo29 jmcdo29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kosh-b @kamilmysliwiec @Tony133 @jmcdo29