Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(hot-reload): Changing a lib not compatible with webpack 5 #1545

Closed
wants to merge 1 commit into from

Conversation

douglasgc
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Docs
[x] Other... Please describe: Changing a lib that was breaking in webpack 5

What is the current behavior?

Hot Reload breaking due to a lib not compatible with webpack 5.
ericclemmons/start-server-webpack-plugin#40
An issue has already been opened and remained unanswered for 29 days.

Issue Number: #5667

What is the new behavior?

Due to the lack of updating of the current library, I created a new NPM package that solves the problem.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@brandon-leapyear
Copy link
Contributor

brandon-leapyear commented Dec 10, 2020

This is an old work account. Please reference @brandonchinn178 for all future communication


How about using run-script-webpack-plugin? See the original comment:

ericclemmons/start-server-webpack-plugin#40 (comment)

@kamilmysliwiec
Copy link
Member

Let's track this here #1621

@douglasgc douglasgc deleted the fix-hot-reload-lib branch March 9, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants